-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource tagging support #599
Add resource tagging support #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Casper da Costa-Luis <[email protected]>
I go to bed and he beats me to it 😆 |
Sleeping, or opening pull requests? 🦦 |
I might be being extra picky but for AWS as the example, the auto-scaling group doesn't get the tag, and more importantly, s3 objects are missing them as well. |
You're picky and it's awesome! 🙏🏼 Tracking this on #601 |
Closes #598